Skip to content

fix existing bazel link removal#8848

Merged
zpcore merged 3 commits intomasterfrom
piz/fix_bazel
Mar 18, 2025
Merged

fix existing bazel link removal#8848
zpcore merged 3 commits intomasterfrom
piz/fix_bazel

Conversation

@zpcore
Copy link
Copy Markdown
Member

@zpcore zpcore commented Mar 18, 2025

In Pytorch upstream CI, which calls .circleci.common.sh. We saw the Failure:

+ sudo npm install -g @bazel/bazelisk
25l[..................] | reify: timing arborist:ctor Completed in 1ms
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps
[..................] | idealTree:lib: sill idealTree buildDeps

25hnpm ERR! code EEXIST
npm ERR! path /usr/local/bin/bazel
npm ERR! EEXIST: file already exists
npm ERR! File exists: /usr/local/bin/bazel
npm ERR! Remove the existing file and try again, or run npm
npm ERR! with --force to overwrite files recklessly.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2025-03-18T13_48_56_943Z-debug.log
...

+ [[ -e /usr/bin/bazel ]]
++ command -v bazelisk
+ sudo ln -s '' /usr/bin/bazel
ln: failed to create symbolic link '/usr/bin/bazel' -> '': No such file or directory

@zpcore zpcore marked this pull request as ready for review March 18, 2025 17:21
@zpcore zpcore requested review from ManfeiBai and pgmoka March 18, 2025 17:21
@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Mar 18, 2025

Also I disable xla/test/test_profiler.py for now to unblock the CI in pytorch upstream. @ysiraichi

@zpcore zpcore requested a review from tengyifei March 18, 2025 17:31
@tengyifei
Copy link
Copy Markdown
Collaborator

Is there a way to test that this PR works? The error

ln: failed to create symbolic link '/usr/bin/bazel' -> '': No such file or directory

suggests to me that which bazelisk is returning '', which is why ln is trying to link /usr/bin/bazel to '' and failing. This suggests that bazelisk installation failed.

Comment thread test/run_tests.sh
@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Mar 18, 2025

Is there a way to test that this PR works? The error

ln: failed to create symbolic link '/usr/bin/bazel' -> '': No such file or directory

suggests to me that which bazelisk is returning '', which is why ln is trying to link /usr/bin/bazel to '' and failing. This suggests that bazelisk installation failed.

The failure is due to sudo npm install -g @bazel/bazelisk failed, which complains /usr/local/bin/bazel already exists.

@tengyifei
Copy link
Copy Markdown
Collaborator

Is there a way to test that this PR works? The error

ln: failed to create symbolic link '/usr/bin/bazel' -> '': No such file or directory

suggests to me that which bazelisk is returning '', which is why ln is trying to link /usr/bin/bazel to '' and failing. This suggests that bazelisk installation failed.

The failure is due to sudo npm install -g @bazel/bazelisk failed, which complains /usr/local/bin/bazel already exists.

Gotcha!

@zpcore zpcore merged commit 18cdb17 into master Mar 18, 2025
@zpcore zpcore deleted the piz/fix_bazel branch March 18, 2025 18:20
zpcore added a commit that referenced this pull request Mar 26, 2025
zpcore added a commit that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants