install jax dependency by default to unblock pytorch ci#8845
Merged
Conversation
tengyifei
reviewed
Mar 17, 2025
tengyifei
approved these changes
Mar 17, 2025
zpcore
added a commit
that referenced
this pull request
Mar 26, 2025
zpcore
added a commit
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch CI is failing when they run XLA test: https://hud.pytorch.org/failure?name=pull+%2F+linux-focal-py3_9-clang9-xla+%2F+test+[…]tures=%5B%22test_call_jax_pytree%22%2C%22TestJaxInterop%22%5D.
They are running the jax related test but didn't install the jax dependencies as we did in https://github.com/pytorch/xla/pull/8781/files.
In Pytorch CI, they use the xla pin and install the package dependency in https://github.com/pytorch/pytorch/blob/afa1eda901b81fa6ce1afe651d3c2da53fa92440/.ci/pytorch/test.sh#L1188. So we only need to make an update from our side.