Conversation
Collaborator
|
You'd need to rebase your branch somehow. Right now there's 9 unrelated commits in the PR. |
Collaborator
Author
I made a branch from master, but did the diff on #8817. That is why we say those commits. Changing the diff has resolved the issue |
tengyifei
approved these changes
Mar 13, 2025
Collaborator
Author
|
Answered comments. Awaiting for @mikegre-google to take another look before merging. |
mikegre-google
approved these changes
Mar 17, 2025
Collaborator
mikegre-google
left a comment
There was a problem hiding this comment.
Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add links and information to help codegen tasks.