Conversation
bhavya01
approved these changes
Mar 12, 2025
bhavya01
reviewed
Mar 12, 2025
Collaborator
bhavya01
left a comment
There was a problem hiding this comment.
Looks like the CI tests failed.
07c6b30 to
417a484
Compare
zpcore
pushed a commit
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #8820
Recently, PyTorch updated its triton pin pytorch/pytorch#148971, making it so our triton tests fail. This PR makes the necessary modifications for accommodating the pin update.
In summary, this PR creates 2 functions
spec_and_divisible_by_16andspec_and_equals_1which are copied from the formerJITFunction._get_config()function. That function (and their analogous versions) was removed from the recent versions of triton.cc @bhavya01