Introduce a GRU module implemented with scan#8777
Merged
Conversation
d2f1d2c to
9ce5718
Compare
qihqi
approved these changes
Mar 3, 2025
pgmoka
pushed a commit
that referenced
this pull request
Mar 5, 2025
This was referenced Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8655
Given that the experimental launch of scan operator that lowers to XLA's WhileOp, we should leverage it to implement performant RNN layers. This PR adds support for a common RNN: Gated Recurrent Unit. It's mostly API compatible with the GRU module found in PyTorch upstream except we only support uni-directional RNN for now.
It should great to leverage it in place of the for loop that loops throught the time dimension, which could be large.