Merged
Conversation
Collaborator
Author
|
At first, I won't add the |
ca03671 to
d567592
Compare
Collaborator
Author
|
@JackCaoG @vanbasten23 It looks like CUDA build/tests are not running. Do I need to add a label for it? |
Collaborator
|
cuda test was disabled on head due to some build issue. |
Collaborator
Author
|
Oh, I see. Is it ok if we merge this one? pytorch/pytorch#138470 was already merged. |
JackCaoG
approved these changes
Dec 5, 2024
rpsilva-aws
pushed a commit
to rpsilva-aws/xla
that referenced
this pull request
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the test introduced in #7213, where it called PyTorch's
to_dlpack()function before actually callingfrom_dlpack(). Meaning that bothTensor.__dlpack__andTensor.__dlpack_device__functions weren't getting called, which were the functions that that test was supposed to be testing.This should be merged after pytorch/pytorch#138470.
cc @JackCaoG @vanbasten23 @qihqi