add dynamo config skip_input_data_check#7913
Merged
Conversation
lsy323
approved these changes
Aug 26, 2024
| run_test "$CDIR/dynamo/test_bridge.py" | ||
| run_test "$CDIR/dynamo/test_num_output.py" | ||
| run_test "$CDIR/dynamo/test_graph_input_matcher.py" | ||
| run_test "$CDIR/dynamo/test_dynamo_config.py" |
Collaborator
Author
There was a problem hiding this comment.
opps.. let me fix..
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Oct 11, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Dec 11, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is introduce the config
skip_input_data_checkwhich will skip an parameter check in dynamo bridge. This code is in the hot path of the dynamo execution and will invoke a pybind + constructuing a boolean array with the same zie of the input parameters.Enabling this will save us ~0.1ms launch overhead.