Conversation
JackCaoG
reviewed
Aug 26, 2024
Collaborator
|
please run both v2 and v4 TPUCI in this pr. |
JackCaoG
reviewed
Aug 26, 2024
JackCaoG
reviewed
Aug 26, 2024
JackCaoG
reviewed
Aug 26, 2024
JackCaoG
reviewed
Aug 26, 2024
Comment on lines
+203
to
+205
| return [ | ||
| KeyError(f"Keys: {missing_keys} are missing from input_sharding.") | ||
| ] |
Collaborator
Author
There was a problem hiding this comment.
This part of the code executes in a separate thread. If an exception happens in the thread, the main thread is just blocked on the _worker thread to load data into the input_batches queue. To explicitly raise the error to the user, I think it might be better if we add the exception to the input batch queue and check for it while passing the data to the main thread in PerDeviceLoader.next function
JackCaoG
reviewed
Aug 26, 2024
JackCaoG
approved these changes
Sep 4, 2024
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
I think we should also mention this in the release note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.