Skip to content

Move the dynamo bridge to the _dynamo repo#7909

Merged
JackCaoG merged 2 commits intomasterfrom
JackCaoG/add_dynamo_config
Aug 26, 2024
Merged

Move the dynamo bridge to the _dynamo repo#7909
JackCaoG merged 2 commits intomasterfrom
JackCaoG/add_dynamo_config

Conversation

@JackCaoG
Copy link
Copy Markdown
Collaborator

@JackCaoG JackCaoG commented Aug 23, 2024

It doesn't make sense to put dynamo_bridge.py under torch_xla.core since user never need to import it. I plan to add dynamo related configs and refactor dynamo bridge so move it to torch_xla/_dynamo/.

Upstream also imports dynamo bridge so I will update that as well

@JackCaoG
Copy link
Copy Markdown
Collaborator Author

JackCaoG commented Aug 23, 2024

I can repo the error locally if I build the wheel and then install

root@t1v-n-a83b02ef-w-0:/workspaces/dk4/pytorch# python -c "import torch_xla"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.10/site-packages/torch_xla/__init__.py", line 236, in <module>
    from .stablehlo import save_as_stablehlo, save_torch_model_as_stablehlo
  File "/usr/local/lib/python3.10/site-packages/torch_xla/stablehlo.py", line 18, in <module>
    from torch_xla._dynamo import dynamo_bridge
ModuleNotFoundError: No module named 'torch_xla._dynamo'

@JackCaoG JackCaoG marked this pull request as ready for review August 23, 2024 23:29
@JackCaoG JackCaoG merged commit a7533b0 into master Aug 26, 2024
@JackCaoG JackCaoG deleted the JackCaoG/add_dynamo_config branch August 26, 2024 17:36
yitongh pushed a commit to AlibabaPAI/xla that referenced this pull request Oct 11, 2024
@JackCaoG @yitongh
Move the dynamo bridge to the _dynamo repo (pytorch#7909)
b3e2e11
yitongh pushed a commit to AlibabaPAI/xla that referenced this pull request Dec 11, 2024
@JackCaoG @yitongh
Move the dynamo bridge to the _dynamo repo (pytorch#7909)
9708b7a
yitongh pushed a commit to AlibabaPAI/xla that referenced this pull request Dec 11, 2024
@JackCaoG @yitongh
Move the dynamo bridge to the _dynamo repo (pytorch#7909)
8e5b2a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsy323 lsy323 lsy323 approved these changes

@alanwaketan alanwaketan Awaiting requested review from alanwaketan

@will-cromar will-cromar Awaiting requested review from will-cromar

Assignees

No one assigned

Labels

dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JackCaoG @lsy323