support eager mode with torch.compile#7256
Merged
Conversation
wonjoo-wj
approved these changes
Jun 12, 2024
vanbasten23
reviewed
Jun 13, 2024
| run_save_tensor_hlo "$CDIR/spmd/test_spmd_graph_dump.py" | ||
| } | ||
|
|
||
| # DO NOT MODIFY |
Collaborator
There was a problem hiding this comment.
I think Yeounoh added the comment because GPU test run_xla_op_tests2 is running so long that all the new tests should be added to run_xla_op_tests3 or later test. This is to reduce the overall CPU/GPU tests running time.
Collaborator
Author
There was a problem hiding this comment.
right, but I think you fixed the AMP taking too long issue, now this test suite actually finished very quickly
JackCaoG
added a commit
that referenced
this pull request
Jul 9, 2024
JackCaoG
added a commit
that referenced
this pull request
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.