Conversation
Collaborator
|
Let's add a test, otherwise LGTM |
lsy323
approved these changes
Jun 10, 2024
Collaborator
Author
|
The correctness check is handled by |
qihqi
approved these changes
Jun 11, 2024
Collaborator
Author
|
Ah.. I need to move this api under experimental.. Let me update the pr... |
Collaborator
Author
|
I am going to skip the gpu tests and it takes forever to get resouce. From last few runs of the CI in this pr, there is nothing specified about the GPU. |
JackCaoG
added a commit
that referenced
this pull request
Jul 2, 2024
JackCaoG
added a commit
that referenced
this pull request
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a eager mode for PyTorch/XLA. We already have an eager mode for debug which is
UseEagerDebugModethat's controlled by a env var. This was contributed by the AWS folks(cc @aws-rhsoln @amithrm @jeffhataws). I decided to make a offical top level api for it.In this pr, I
use_eager_modealong with all the pybindsPT_XLA_DEBUGandPT_XLA_DEBUG_LEVELdoes not print analysis for eager executionFor future pr
For a 2 layer decoder only model, eager mode can acheive ~40% of throuput compared to the full compiled mode.