upsample_bilinear: fix output data-type.#7111
Merged
Conversation
3a27d9b to
7cfe9b1
Compare
JackCaoG
approved these changes
May 28, 2024
Collaborator
|
Seems like you need to resolve the conflict first. |
7cfe9b1 to
2c738c3
Compare
Collaborator
|
I am going to revert this pr as it breaks the TPU CI. considering makeing this change GPU only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #7095
This PR removes the data-type conversion inherited from the TF implementation when
is_kernel_bilinearis set. We still do it on integer data-types, though.Note:
upsample_bilinearcall on integral tensors (excepttorch.bytetype) is not currently implemented on upstream PyTorch. It fails with:cc @miladm @JackCaoG