Conversation
wonjoo-wj
approved these changes
Apr 3, 2024
JackCaoG
approved these changes
Apr 3, 2024
JackCaoG
pushed a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: Siyuan Liu <lsiyuan@google.coim>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dtype_optionalis anc10::optional<at::ScalarType>object, dereferencing it without checking if it's null in line 1605 is not expected.The logic should be have the result have the same dtype as input if the output dtype is not explicitly set.
Test:
I cannot repro this is a unit test, only in a real model. I think that's because of the randomness in dereferencing
c10::optional