Skip to content

Add a DynamoSyncInputExecuteTime counter#6813

Merged
JackCaoG merged 4 commits intomasterfrom
JackCao/Dynamo_sync_input_counter
Apr 1, 2024
Merged

Add a DynamoSyncInputExecuteTime counter#6813
JackCaoG merged 4 commits intomasterfrom
JackCao/Dynamo_sync_input_counter

Conversation

@JackCaoG
Copy link
Copy Markdown
Collaborator

Aot-autograd might apply reshape on the input before passing to openxla backend, in that case we need to execute to sync the input. Add a counter to track that.

@JackCaoG JackCaoG requested a review from wonjoo-wj March 23, 2024 00:22
Comment thread test/dynamo/test_dynamo.py Outdated
xla_y3 = xla_y * 3
res_xla_dynamo_3 = fn_simple_dynamo(xla_xy, xla_y3)
res_cpu_3 = self.fn_simple(x + y, y * 3)
breakpoint()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove 😄

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@wonjoo-wj
Copy link
Copy Markdown
Collaborator

LGTM, the breakpoint seems to be causing the CI to fail, but otherwise LGTM.

@JackCaoG
Copy link
Copy Markdown
Collaborator Author

Let me rebase this pr

@JackCaoG JackCaoG force-pushed the JackCao/Dynamo_sync_input_counter branch from 748e713 to e3a7c37 Compare March 29, 2024 19:53
@JackCaoG JackCaoG enabled auto-merge (squash) April 1, 2024 18:58
@JackCaoG
Copy link
Copy Markdown
Collaborator Author

JackCaoG commented Apr 1, 2024

opps, @wonjoolee95 do you mind stamping this pr?

@JackCaoG JackCaoG merged commit c1773b6 into master Apr 1, 2024
yitongh pushed a commit to AlibabaPAI/xla that referenced this pull request Oct 11, 2024
yitongh pushed a commit to AlibabaPAI/xla that referenced this pull request Dec 11, 2024
yitongh pushed a commit to AlibabaPAI/xla that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants