[Core Aten Ops] Lower reflection_pad1d, reflection_pad1d_backward, reflection_pad3d and reflection_pad3d_backward by ManfeiBai · Pull Request #6588 · pytorch/xla

ManfeiBai · 2024-02-22T05:07:08Z

follow PR for #6559

Test

# pytest test/test_core_aten_ops.py -k test_aten_reflection_pad1d_0
=========================== test session starts ============================
platform linux -- Python 3.10.13, pytest-8.0.1, pluggy-1.4.0
rootdir: /root/pytorch
configfile: pytest.ini
plugins: hypothesis-6.98.9
collected 490 items / 489 deselected / 1 selected                          

test/test_core_aten_ops.py WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1708580905.348960  120407 pjrt_api.cc:100] GetPjrtApi was found for tpu at /root/miniconda3/envs/newtorch310/lib/python3.10/site-packages/libtpu/libtpu.so
I0000 00:00:1708580905.349050  120407 pjrt_api.cc:79] PJRT_Api is set for device type tpu
I0000 00:00:1708580905.349063  120407 pjrt_api.cc:146] The PJRT plugin has PJRT API version 0.40. The framework PJRT API version is 0.40.
.                                         [100%]

==================== 1 passed, 489 deselected in 6.52s =====================
# pytest test/test_core_aten_ops.py -k test_aten_reflection_pad1d_1
=========================== test session starts ============================
platform linux -- Python 3.10.13, pytest-8.0.1, pluggy-1.4.0
rootdir: /root/pytorch
configfile: pytest.ini
plugins: hypothesis-6.98.9
collected 490 items / 489 deselected / 1 selected                          

test/test_core_aten_ops.py WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1708580948.256937  122008 pjrt_api.cc:100] GetPjrtApi was found for tpu at /root/miniconda3/envs/newtorch310/lib/python3.10/site-packages/libtpu/libtpu.so
I0000 00:00:1708580948.257028  122008 pjrt_api.cc:79] PJRT_Api is set for device type tpu
I0000 00:00:1708580948.257039  122008 pjrt_api.cc:146] The PJRT plugin has PJRT API version 0.40. The framework PJRT API version is 0.40.
.                                         [100%]

==================== 1 passed, 489 deselected in 6.77s =====================
# pytest test/test_core_aten_ops.py -k test_aten_reflection_pad3d_0
=========================== test session starts ============================
platform linux -- Python 3.10.13, pytest-8.0.1, pluggy-1.4.0
rootdir: /root/pytorch
configfile: pytest.ini
plugins: hypothesis-6.98.9
collected 490 items / 489 deselected / 1 selected                          

test/test_core_aten_ops.py WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1708580959.660941  123608 pjrt_api.cc:100] GetPjrtApi was found for tpu at /root/miniconda3/envs/newtorch310/lib/python3.10/site-packages/libtpu/libtpu.so
I0000 00:00:1708580959.661037  123608 pjrt_api.cc:79] PJRT_Api is set for device type tpu
I0000 00:00:1708580959.661047  123608 pjrt_api.cc:146] The PJRT plugin has PJRT API version 0.40. The framework PJRT API version is 0.40.
.                                         [100%]

==================== 1 passed, 489 deselected in 6.89s =====================
# pytest test/test_core_aten_ops.py -k test_aten_reflection_pad3d_1
=========================== test session starts ============================
platform linux -- Python 3.10.13, pytest-8.0.1, pluggy-1.4.0
rootdir: /root/pytorch
configfile: pytest.ini
plugins: hypothesis-6.98.9
collected 490 items / 489 deselected / 1 selected                          

test/test_core_aten_ops.py WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1708580971.032931  125211 pjrt_api.cc:100] GetPjrtApi was found for tpu at /root/miniconda3/envs/newtorch310/lib/python3.10/site-packages/libtpu/libtpu.so
I0000 00:00:1708580971.033014  125211 pjrt_api.cc:79] PJRT_Api is set for device type tpu
I0000 00:00:1708580971.033027  125211 pjrt_api.cc:146] The PJRT plugin has PJRT API version 0.40. The framework PJRT API version is 0.40.
.                                         [100%]

==================== 1 passed, 489 deselected in 6.94s =====================
# pytest test/test_core_aten_ops.py -k test_aten_reflection_pad3d_2
=========================== test session starts ============================
platform linux -- Python 3.10.13, pytest-8.0.1, pluggy-1.4.0
rootdir: /root/pytorch
configfile: pytest.ini
plugins: hypothesis-6.98.9
collected 490 items / 489 deselected / 1 selected                          

test/test_core_aten_ops.py WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1708580982.132929  126817 pjrt_api.cc:100] GetPjrtApi was found for tpu at /root/miniconda3/envs/newtorch310/lib/python3.10/site-packages/libtpu/libtpu.so
I0000 00:00:1708580982.133012  126817 pjrt_api.cc:79] PJRT_Api is set for device type tpu
I0000 00:00:1708580982.133025  126817 pjrt_api.cc:146] The PJRT plugin has PJRT API version 0.40. The framework PJRT API version is 0.40.
.                                         [100%]

==================== 1 passed, 489 deselected in 6.77s =====================

Notice: we keep use BuildReflectionPadBackward and BuildReflectionPad2d here due to the at::aten::reflection_pad2d_backward named already: code

wonjoo-wj · 2024-02-22T06:30:29Z

Thanks for getting this PR out so quickly. I'll take a look tomorrow morning, thanks!

wonjoo-wj · 2024-02-22T17:09:50Z

Seems like the CPP tests are failing, can you take a look? Thanks!

ManfeiBai · 2024-02-22T19:10:34Z

Seems like the CPP tests are failing, can you take a look? Thanks!

Thanks, they are failed due to the padding dimension, pushed new commit and triggered test again

wonjoo-wj

LGTM, thanks!

wonjoo-wj · 2024-02-23T17:46:14Z

Kokoro build failure timeout should be fixed on master, I'll merge this.

…flection_pad3d and reflection_pad3d_backward (pytorch#6588)

ManfeiBai added 7 commits February 21, 2024 21:07

Update xla_native_functions.yaml

b15ce9f

Update aten_xla_type.cpp

b5fb07b

Update tensor_methods.cpp

ef876bd

Update tensor_methods.h

cb3e522

Update tensor_methods.cpp

607162d

Update test_core_aten_ops.py

223a246

Update test_aten_xla_tensor_3.cpp

3a700ea

ManfeiBai force-pushed the ManfeiBai-patch-72 branch from 6262f12 to 3a700ea Compare February 22, 2024 06:03

Update tensor_methods.cpp

adb9031

ManfeiBai changed the title ~~Update xla_native_functions.yaml~~ [Core Aten Ops] Lower reflection_pad1d, reflection_pad1d_backward, reflection_pad3d and reflection_pad3d_backward Feb 22, 2024

Update tensor_methods.cpp

65529c9

ManfeiBai marked this pull request as ready for review February 22, 2024 06:14

ManfeiBai requested a review from wonjoo-wj February 22, 2024 06:15

Update test_aten_xla_tensor_3.cpp

136df9f

ManfeiBai added 9 commits February 22, 2024 13:08

Update test_aten_xla_tensor_3.cpp

ff8fffc

Update test_aten_xla_tensor_3.cpp

99b1cb6

Update test_aten_xla_tensor_3.cpp

d087c37

Update test_aten_xla_tensor_3.cpp

7f7de70

Update test_aten_xla_tensor_3.cpp

303cb84

Update test_aten_xla_tensor_3.cpp

89b0162

Update test_aten_xla_tensor_3.cpp

1cf2190

Update test_aten_xla_tensor_3.cpp

cd725c3

Update test_aten_xla_tensor_3.cpp

23c18cf

qihqi approved these changes Feb 23, 2024

View reviewed changes

wonjoo-wj approved these changes Feb 23, 2024

View reviewed changes

wonjoo-wj merged commit 13e8647 into master Feb 23, 2024

amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024

[Core Aten Ops] Lower reflection_pad1d, reflection_pad1d_backward, re…

a1d3924

…flection_pad3d and reflection_pad3d_backward (pytorch#6588)

ManfeiBai added the q1_2024_manfei label Mar 22, 2024

ManfeiBai added the core aten opset label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Core Aten Ops] Lower reflection_pad1d, reflection_pad1d_backward, reflection_pad3d and reflection_pad3d_backward#6588

[Core Aten Ops] Lower reflection_pad1d, reflection_pad1d_backward, reflection_pad3d and reflection_pad3d_backward#6588
wonjoo-wj merged 19 commits intomasterfrom
ManfeiBai-patch-72

ManfeiBai commented Feb 22, 2024 •

edited

Loading

Uh oh!

wonjoo-wj commented Feb 22, 2024

Uh oh!

wonjoo-wj commented Feb 22, 2024

Uh oh!

ManfeiBai commented Feb 22, 2024 •

edited

Loading

Uh oh!

wonjoo-wj left a comment

Uh oh!

wonjoo-wj commented Feb 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ManfeiBai commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wonjoo-wj commented Feb 22, 2024

Uh oh!

wonjoo-wj commented Feb 22, 2024

Uh oh!

ManfeiBai commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wonjoo-wj left a comment

Choose a reason for hiding this comment

Uh oh!

wonjoo-wj commented Feb 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ManfeiBai commented Feb 22, 2024 •

edited

Loading

ManfeiBai commented Feb 22, 2024 •

edited

Loading