Do not cache input args in dynamo bridge#6553
Merged
Conversation
Collaborator
Author
|
Hi @wonjoolee95 @JackCaoG, this PR is ready for review. The CI failed because of the staled GCP token. I ran the dynamo tests locally and they passed. |
JackCaoG
reviewed
Feb 21, 2024
JackCaoG
approved these changes
Feb 21, 2024
wonjoo-wj
approved these changes
Feb 21, 2024
JackCaoG
reviewed
Feb 21, 2024
JackCaoG
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not cache FX Graph args in
GraphInputMatcher. It's not necessary to cache those tensors, because user inputs will be used in each run.Without this change, the cached input tensors will cause more device memory usage as new graph is cached.
xla_argsis the user inputs passed down from Dynamo, the cached tensors are released based on thetensor_idofxla_args, when eachGraphInputMatcheris constructed.