Skip to content

Lowering for _pdist_forward#6507

Merged
wonjoo-wj merged 3 commits intomasterfrom
piz/aten
Feb 12, 2024
Merged

Lowering for _pdist_forward#6507
wonjoo-wj merged 3 commits intomasterfrom
piz/aten

Conversation

@zpcore
Copy link
Copy Markdown
Member

@zpcore zpcore commented Feb 8, 2024

Resolves #5885.

@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Feb 8, 2024

Oh, there is test failure in pytorch size for corner case shape [0,2], [1,2] and [3,0]: https://github.com/pytorch/pytorch/blob/a8d1645f156c6e8833c11eb1fc32ce45147575ac/test/test_torch.py#L2366.
Let me make the fix.

Comment thread torch_xla/csrc/ops/ops.cpp
@zpcore zpcore requested a review from lsy323 February 9, 2024 17:31
Copy link
Copy Markdown
Collaborator

@wonjoo-wj wonjoo-wj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wonjoo-wj wonjoo-wj merged commit a5856f9 into master Feb 12, 2024
@zpcore zpcore deleted the piz/aten branch February 12, 2024 17:36
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Core ATen Opset] Lower aten__pdist_forward

2 participants