test_zero1 passes on GPU with latest torch/xla (commit e1c94df)#6268
Merged
alanwaketan merged 1 commit intomasterfrom Jan 8, 2024
Merged
test_zero1 passes on GPU with latest torch/xla (commit e1c94df)#6268alanwaketan merged 1 commit intomasterfrom
alanwaketan merged 1 commit intomasterfrom
Conversation
Collaborator
|
LGTM. |
alanwaketan
approved these changes
Jan 8, 2024
Collaborator
|
Thanks, Jeff. |
jeffhataws
added a commit
that referenced
this pull request
Jan 9, 2024
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
Collaborator
|
Hi @jeffhataws , our team found a regression on the master branch due to the PR #6247. Since this PR depends on #6247, this PR needs to be reverted unfortunately from the master branch and the r2.2 branch #6321. |
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reenables test/test_zero1.py for GPU. It is passing with latest torch/xla (commit e1c94df).
#6260