benchmarks/torchbench_model: skip benchmarks that fail to load#6199
Merged
cota merged 1 commit intopytorch:masterfrom Dec 20, 2023
Merged
benchmarks/torchbench_model: skip benchmarks that fail to load#6199cota merged 1 commit intopytorch:masterfrom
cota merged 1 commit intopytorch:masterfrom
Conversation
a067171 to
fbf0916
Compare
frgossen
approved these changes
Dec 18, 2023
Collaborator
frgossen
left a comment
There was a problem hiding this comment.
Thanks! If this is a wider spread issue, we should investigate further. Can we add an issue for this one?
Collaborator
Author
|
|
d931dc8 to
54599a6
Compare
Collaborator
Author
|
I've added the necessary models to the deny list as a workaround. I've also filed issue #6207 and referenced it from the code change so that we do not forget why they were added to the deny list. |
golechwierowicz
approved these changes
Dec 19, 2023
In "dfcf306e7 Apply precision config env vars in the root process. (pytorch#6152)" we started running load_benchmark() from experiment_runner's main process. Unfortunately, load_benchmark() for some models does exit the calling process, which results in experiment_runner exiting prematurely. Work around this issue by adding these models to the deny list, so that experiment_runner does not die early.
cota
added a commit
to cota/pytorch-xla
that referenced
this pull request
Dec 21, 2023
Add Inductor to the deny list for two benchmarks. Note: I should have added these already in "3ccb4ed2a benchmarks/torchbench_model: skip benchmarks that fail to load (pytorch#6199)". This fixes that oversight.
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Jan 3, 2024
…ch#6199) In "dfcf306e7 Apply precision config env vars in the root process. (pytorch#6152)" we started running load_benchmark() from experiment_runner's main process. Unfortunately, load_benchmark() for some models does exit the calling process, which results in experiment_runner exiting prematurely. Work around this issue by adding these models to the deny list, so that experiment_runner does not die early.
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
In "dfcf306e7 Apply precision config env vars in the root process. (#6152)" we started running load_benchmark() from experiment_runner's main process. Unfortunately, load_benchmark() for some models does exit the calling process, which results in experiment_runner exiting prematurely. Work around this issue by adding these models to the deny list, so that experiment_runner does not die early.
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
In "dfcf306e7 Apply precision config env vars in the root process. (#6152)" we started running load_benchmark() from experiment_runner's main process. Unfortunately, load_benchmark() for some models does exit the calling process, which results in experiment_runner exiting prematurely. Work around this issue by adding these models to the deny list, so that experiment_runner does not die early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In "dfcf306e7 Apply precision config env vars in the root process. (#6152)"
we started running load_benchmark() from experiment_runner's
main process. Unfortunately, load_benchmark() for
some models does exit the calling process, which results
in experiment_runner exiting prematurely.
Work around this issue by adding these models to the deny list,
so that experiment_runner does not die early.