Add documentation and python API for persistent cache#6046
Merged
Conversation
5b01521 to
bb4a63a
Compare
will-cromar
approved these changes
Dec 7, 2023
Collaborator
will-cromar
left a comment
There was a problem hiding this comment.
Nice! I prefer the Python API to the environment variables. +1 to eliminating env vars as the way we communicate between Python and C++
JackCaoG
reviewed
Dec 7, 2023
Comment on lines
+282
to
+283
| # TODO(jonbolin): Consider moving away from environment variables to control | ||
| # the cache. |
Collaborator
There was a problem hiding this comment.
yea I think it is a good idea to just drop env var going forward.
JackCaoG
approved these changes
Dec 7, 2023
Closed
Contributor
|
cc @zpcore for visibility |
jonb377
added a commit
that referenced
this pull request
Dec 7, 2023
jonb377
added a commit
that referenced
this pull request
Dec 8, 2023
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a Python API to activate the persistent cache, rather than controlling it exclusively through environment variables.