Refactor type conversion functions out of //torch_xla/csrc:tensor#5777
Merged
will-cromar merged 9 commits intomasterfrom Nov 9, 2023
Merged
Refactor type conversion functions out of //torch_xla/csrc:tensor#5777will-cromar merged 9 commits intomasterfrom
//torch_xla/csrc:tensor#5777will-cromar merged 9 commits intomasterfrom
Conversation
JackCaoG
reviewed
Nov 8, 2023
| for (auto& literal : literals) { | ||
| tensors.push_back(MakeTensorFromXlaLiteral( | ||
| literal, TensorTypeFromXlaType(literal.shape().element_type()))); | ||
| literal, MaybeUpcastForHost(literal.shape().element_type()))); |
Collaborator
There was a problem hiding this comment.
I understand the motivation of this renaming but it made it less obvious to see this function does a conversation from XLA type to Tensor type. MaybeUpcastXlaTypeToTensorType? Same for the downcast.
Collaborator
Author
There was a problem hiding this comment.
Done. Renamed to MaybeUpcastToHostTorchType and MaybeDowncastToXlaDeviceType to clarify the return type.
JackCaoG
approved these changes
Nov 8, 2023
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
…ytorch#5777) * Move pure dtype conversion functions to `dtype.cpp` * remove comments * better names * fix includes * formatting * consolidate * fix test build * more explicit names * remove extra line
zpcore
pushed a commit
that referenced
this pull request
Nov 21, 2023
…5777) * Move pure dtype conversion functions to `dtype.cpp` * remove comments * better names * fix includes * formatting * consolidate * fix test build * more explicit names * remove extra line
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
…5777) * Move pure dtype conversion functions to `dtype.cpp` * remove comments * better names * fix includes * formatting * consolidate * fix test build * more explicit names * remove extra line
ManfeiBai
pushed a commit
that referenced
this pull request
Nov 29, 2023
…5777) * Move pure dtype conversion functions to `dtype.cpp` * remove comments * better names * fix includes * formatting * consolidate * fix test build * more explicit names * remove extra line
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
…ytorch#5777) * Move pure dtype conversion functions to `dtype.cpp` * remove comments * better names * fix includes * formatting * consolidate * fix test build * more explicit names * remove extra line
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
…5777) * Move pure dtype conversion functions to `dtype.cpp` * remove comments * better names * fix includes * formatting * consolidate * fix test build * more explicit names * remove extra line
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
…5777) * Move pure dtype conversion functions to `dtype.cpp` * remove comments * better names * fix includes * formatting * consolidate * fix test build * more explicit names * remove extra line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps prevent circular dependencies. See #5772 for motivation.
dtype.cpp/hfor type conversions.switchstatements.