Patch RNG for better memory utilization in dropout layers#5710
Merged
Patch RNG for better memory utilization in dropout layers#5710
Conversation
3c06cd2 to
3c3ef36
Compare
JackCaoG
approved these changes
Oct 17, 2023
Collaborator
|
do we want to add a test to check that int8 is used for rng? I think we can check the HLO generated, |
Contributor
Author
Hey Jack, yea good idea, will add before merging. |
3c3ef36 to
5988f45
Compare
df85d09 to
e26a3ee
Compare
e26a3ee to
6f3dda6
Compare
Contributor
Author
Verified locally with the new unit test -- cc @JackCaoG |
ghpvnist
pushed a commit
to ghpvnist/pytorch-xla
that referenced
this pull request
Oct 31, 2023
* Enable u8 rng-bit-generator with downcast * Use BF16 values if downcast for uniform dist is set.
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
* Enable u8 rng-bit-generator with downcast * Use BF16 values if downcast for uniform dist is set.
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* Enable u8 rng-bit-generator with downcast * Use BF16 values if downcast for uniform dist is set.
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Enable u8 rng-bit-generator with downcast * Use BF16 values if downcast for uniform dist is set.
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Enable u8 rng-bit-generator with downcast * Use BF16 values if downcast for uniform dist is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch has landed in OpenXLA openxla/xla#6015, we can enable this now, to reduce memory pressure in
nn.Dropoutlayer.DO_NOT_MERGE until the next pin update.