Support async checkpointing through CheckpointManager#5697
Merged
Conversation
alanwaketan
reviewed
Oct 11, 2023
yeounoh
reviewed
Oct 12, 2023
yeounoh
approved these changes
Oct 12, 2023
Contributor
yeounoh
left a comment
There was a problem hiding this comment.
LGTM, left some questions.
b9e1952 to
273ef2f
Compare
ad02d56 to
fdecad3
Compare
zpcore
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Support async checkpointing through CheckpointManager * Allow threads to exit when CheckpointManager is freed * Use rank from tracked process group * Add TODO
ghpvnist
pushed a commit
to ghpvnist/pytorch-xla
that referenced
this pull request
Oct 31, 2023
* Support async checkpointing through CheckpointManager * Allow threads to exit when CheckpointManager is freed * Use rank from tracked process group * Add TODO
Collaborator
Author
|
cc @wz337 |
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
* Support async checkpointing through CheckpointManager * Allow threads to exit when CheckpointManager is freed * Use rank from tracked process group * Add TODO
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* Support async checkpointing through CheckpointManager * Allow threads to exit when CheckpointManager is freed * Use rank from tracked process group * Add TODO
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Support async checkpointing through CheckpointManager * Allow threads to exit when CheckpointManager is freed * Use rank from tracked process group * Add TODO
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Support async checkpointing through CheckpointManager * Allow threads to exit when CheckpointManager is freed * Use rank from tracked process group * Add TODO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support asynchronous checkpointing through the CheckpointManager interface. This will move the state_dict to CPU before starting the checkpoint, which unblocks the calling thread.
This PR depends on #5693 for synchronous checkpointing functionality.