lower native_dropout#5643

Merged

zpcore merged 8 commits intomasterfrom

Sep 26, 2023

Member

zpcore commented Sep 25, 2023

Fix #5588.

Added the manual lowering for native_dropout op. We need to add the test to verify whether the logic is correct or not.

zpcore added 2 commits

September 23, 2023 00:27


          prototype version (compiling error)

82cfaf8


          Add native_dropout manual lowering.

b10efd0

zpcore added the codegen label

zpcore requested review from JackCaoG, lsy323 and yeounoh

September 25, 2023 15:58

lsy323 reviewed

View reviewed changes

torch_xla/csrc/ops/native_dropout.cpp

lsy323 reviewed

View reviewed changes

torch_xla/csrc/ops/native_dropout.cpp

lsy323 changed the title ~~Piz/codegen 1~~ lower native_dropout


          fix to tensor IR and add a simple native_dropout test

eef333a

JackCaoG reviewed

View reviewed changes

test/cpp/test_aten_xla_tensor_1.cpp Outdated

lsy323 reviewed

View reviewed changes

torch_xla/csrc/ops/native_dropout.cpp Outdated

torch_xla/csrc/ops/native_dropout.cpp Outdated

lsy323 reviewed

View reviewed changes

test/cpp/test_aten_xla_tensor_1.cpp

lsy323 reviewed

View reviewed changes

test/cpp/test_aten_xla_tensor_1.cpp Outdated

lsy323 reviewed

View reviewed changes

test/cpp/test_aten_xla_tensor_1.cpp Outdated

torch_xla/csrc/tensor_methods.cpp Outdated

zpcore added lowering and removed codegen labels

lsy323 reviewed

View reviewed changes

torch_xla/csrc/xla_lower_util.cpp Outdated

lsy323 reviewed

View reviewed changes

torch_xla/csrc/ops/native_dropout.cpp


          fix data type issue and update test case

lsy323 reviewed

View reviewed changes

torch_xla/csrc/ops/native_dropout.cpp Outdated

torch_xla/csrc/xla_lower_util.cpp Outdated

lsy323 reviewed

View reviewed changes

torch_xla/csrc/ops/native_dropout.cpp Outdated

zpcore added 2 commits

September 26, 2023 00:56


          fix IR hash issue

1139c82


          fix corner case when probability==0

459ab22

lsy323 reviewed

View reviewed changes

torch_xla/csrc/xla_lower_util.cpp Outdated


          remove typo line

3d69346

lsy323 reviewed

View reviewed changes

test/cpp/test_aten_xla_tensor_1.cpp Outdated

lsy323 reviewed

View reviewed changes

torch_xla/csrc/xla_lower_util.cpp Outdated

lsy323 reviewed

View reviewed changes

torch_xla/csrc/ops/native_dropout.cpp


          add test case when probability=0

498be74

lsy323 approved these changes

View reviewed changes

Collaborator

lsy323 commented Sep 26, 2023

@zpcore Thanks for working on this, good work!

zpcore merged commit 2c6e4a7 into master

Member Author

zpcore commented Sep 26, 2023

Thanks @JackCaoG and @lsy323 for the feedback, it's a great learning experience!

zpcore deleted the piz/codegen-1 branch

September 26, 2023 16:45

vanbasten23 reviewed

View reviewed changes

test/cpp/test_aten_xla_tensor_1.cpp

ManfeiBai pushed a commit that referenced this pull request


          lower native_dropout (#5643)

8d3171c

* prototype version (compiling error)

* Add native_dropout manual lowering.

* fix to tensor IR and add a simple native_dropout test

* fix data type issue and update test case

* fix IR hash issue

* fix corner case when probability==0

* remove typo line

* add test case when probability=0

ManfeiBai mentioned this pull request

lower NativeDropoutBackward (#5642) and lower native_dropout (#5643) #5647

Merged

ManfeiBai added a commit that referenced this pull request


          lower NativeDropoutBackward (#5642) and lower native_dropout (#5643) (#…

b840137

…5647)

* lower NativeDropoutBackward (#5642)

* lower NativeDropoutBackward

* fix lowering and add python test

* lower native_dropout (#5643)

* prototype version (compiling error)

* Add native_dropout manual lowering.

* fix to tensor IR and add a simple native_dropout test

* fix data type issue and update test case

* fix IR hash issue

* fix corner case when probability==0

* remove typo line

* add test case when probability=0

---------

Co-authored-by: JackCaoG <59073027+JackCaoG@users.noreply.github.com>
Co-authored-by: zpcore <piz@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels