Skip to content

XLA pin downgrade to 20230825#5592

Merged
JackCaoG merged 1 commit intomasterfrom
alanwaketan/pin2
Sep 18, 2023
Merged

XLA pin downgrade to 20230825#5592
JackCaoG merged 1 commit intomasterfrom
alanwaketan/pin2

Conversation

@alanwaketan
Copy link
Copy Markdown
Collaborator

Summary:
The 20230826 version contains openxla/xla@3b8a539 whch regresses our LLaMA2 GSPMD training benchmark. Let's rollback to version before it.

Test Plan:
CI.

Summary:
The 20230826 version contains openxla/xla@3b8a539
whch regresses our LLaMA2 GSPMD training benchmark. Let's rollback to version
before it.

Test Plan:
CI.
@alanwaketan alanwaketan self-assigned this Sep 15, 2023
Copy link
Copy Markdown
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackCaoG
Copy link
Copy Markdown
Collaborator

does this needs to go into for 2.1 branch?

@alanwaketan
Copy link
Copy Markdown
Collaborator Author

does this needs to go into for 2.1 branch?

Yea

@JackCaoG JackCaoG merged commit 9e1f87d into master Sep 18, 2023
ManfeiBai pushed a commit to ManfeiBai/PyTorchXLA that referenced this pull request Sep 18, 2023
Summary:
The 20230826 version contains openxla/xla@3b8a539
whch regresses our LLaMA2 GSPMD training benchmark. Let's rollback to version
before it.

Test Plan:
CI.
ManfeiBai added a commit that referenced this pull request Sep 19, 2023
Summary:
The 20230826 version contains openxla/xla@3b8a539
whch regresses our LLaMA2 GSPMD training benchmark. Let's rollback to version
before it.

Test Plan:
CI.

Co-authored-by: Jiewen Tan <jwtan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants