Remove on_device_shape and logical_on_device_shape#5546
Merged
will-cromar merged 6 commits intomasterfrom Sep 19, 2023
Merged
Conversation
on_device_shape and logical_on_device_shapeon_device_shape and logical_on_device_shape
Collaborator
Author
|
Once the openXLA change to add |
JackCaoG
approved these changes
Sep 9, 2023
9e1c0da to
e180883
Compare
vanbasten23
approved these changes
Sep 13, 2023
Collaborator
Author
|
The upstream commit merged: openxla/xla@6308dba Added the hash to the patch in this commit. Let's wait until after we're done moving the OpenXLA pin to merge this (see #5592) |
Collaborator
|
Do we want this PR in 2.1 branch? |
Collaborator
Author
|
No. This is a risky change, so we should not backport it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were removed from the PJRT C API client recently in this commit: tensorflow/tensorflow@840633c
Instead, we can rebuild the shapes from the decomposed components. In the future, we should see if we can remove
ShapefromComputationClient::Dataentirely in favor ofdimensions,layout, etc.