[Functionalization] Move nan_to_num_ and _amp_foreach_non_finite_check_and_unscale_ op tests to python#4687
Merged
wonjoo-wj merged 2 commits intofunctionalizationfrom Feb 24, 2023
Conversation
e287a9b to
bd0bc8e
Compare
alanwaketan
reviewed
Feb 23, 2023
alanwaketan
reviewed
Feb 23, 2023
alanwaketan
approved these changes
Feb 23, 2023
Collaborator
alanwaketan
left a comment
There was a problem hiding this comment.
Please improve the test case as suggested. Otherwise, LGTM.
alanwaketan
reviewed
Feb 24, 2023
5bd4743 to
d527999
Compare
63f3026 to
71b68f8
Compare
Collaborator
|
You will need to rebase to resolve the new test failure. |
71b68f8 to
9299fc8
Compare
Collaborator
Author
|
Merging this as CIs are all green. |
alanwaketan
pushed a commit
that referenced
this pull request
Mar 1, 2023
…k_and_unscale_ op tests to python (#4687) * Move nan_to_num_ and _amp_foreach_non_finite_check_and_unscale_ op tests to python * Update test call to runAtenTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
nan_to_num_and_amp_foreach_non_finite_check_and_unscale_op tests to pythonEven after pytorch/pytorch#94633, we were still seeing failures complaining about meta tensor support. However, these ops were succeeding during manual tests in Python. My guess would be that somewhere during the decomposition in the C++ world is causing some problems. However, for now, moving these op tests to Python.
Locally, I can see they succeed: