Skip to content

Implement XLASymNodeImpl.has_hint and re-enable failing DS tests.#4678

Merged
vanbasten23 merged 3 commits intofunctionalizationfrom
fix_more_ds_tests
Feb 23, 2023
Merged

Implement XLASymNodeImpl.has_hint and re-enable failing DS tests.#4678
vanbasten23 merged 3 commits intofunctionalizationfrom
fix_more_ds_tests

Conversation

@vanbasten23
Copy link
Copy Markdown
Collaborator

@vanbasten23 vanbasten23 commented Feb 22, 2023

No description provided.

@vanbasten23 vanbasten23 changed the base branch from master to functionalization February 22, 2023 23:39
vanbasten23
vanbasten23 commented Feb 23, 2023
View reviewed changes
Comment thread torch_xla/csrc/tensor.cpp
@vanbasten23 vanbasten23 added the dynamism Dynamic Shape Features label Feb 23, 2023
@vanbasten23 vanbasten23 marked this pull request as ready for review February 23, 2023 00:22
@vanbasten23 vanbasten23 merged commit 5bd4743 into functionalization Feb 23, 2023
alanwaketan pushed a commit that referenced this pull request Feb 24, 2023
@vanbasten23 @alanwaketan
Implement XLASymNodeImpl.has_hint and re-enable failing DS tests. (#4678
d527999 
)

* implement has_hint

* fix linter

* reenable DS tests.
alanwaketan pushed a commit that referenced this pull request Mar 1, 2023
@vanbasten23 @alanwaketan
Implement XLASymNodeImpl.has_hint and re-enable failing DS tests. (#4678
a91684f 
)

* implement has_hint

* fix linter

* reenable DS tests.
@vanbasten23 vanbasten23 mentioned this pull request Mar 10, 2023
Closed
vanbasten23 added a commit that referenced this pull request Apr 29, 2023
@vanbasten23
Implement XLASymNodeImpl.has_hint and re-enable failing DS tests. (#4678
1946763 
)

* implement has_hint

* fix linter

* reenable DS tests.
vanbasten23 added a commit that referenced this pull request May 12, 2023
@vanbasten23
Implement XLASymNodeImpl.has_hint and re-enable failing DS tests. (#4678
3651440 
)

* implement has_hint

* fix linter

* reenable DS tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@alanwaketan alanwaketan alanwaketan approved these changes

@JackCaoG JackCaoG Awaiting requested review from JackCaoG

@miladm miladm Awaiting requested review from miladm

Assignees

No one assigned

Labels

dynamism Dynamic Shape Features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vanbasten23 @ezyang @alanwaketan