Remove deprecated torch.symeig#4498
Conversation
|
@lsy323 can you follow up? |
|
is nvm, saw in the comment |
Yes, it was deprecated since the 1.9 release and it's finally time to remove it. |
lsy323
left a comment
There was a problem hiding this comment.
symeig is also referenced in test/pytorch_test_base.py and test/test_ops.py, you may want to remove those lines as well. Otherwise LGTM, pending on CI completion.
|
|
||
| SymEig::SymEig(const torch::lazy::Value& input, bool eigenvectors, bool lower) | ||
| : XlaNode(torch::lazy::OpKind(at::aten::symeig), {input}, | ||
| : XlaNode(torch::lazy::OpKind(at::aten::linalg_eigh), {input}, |
There was a problem hiding this comment.
Should we remove symeig.h/.cpp since the operator is deprecated. Or you want to rename it to linalg_eigh in the 2nd PR which adds linalg_eigh?
There was a problem hiding this comment.
This file and implementation will be used for the new linalg_eigh.
|
Removed mentions of symeig in |
Thanks! Let's merge upon CI completion. |
|
Hi @IvanYashchuk, The CI failure is not related to this change. #4502 disabled the failed test and is already merged. Let's rebase after HEAD is green again. Thanks Ivan! Best, |
|
Tests fails with: |
|
Hi @IvanYashchuk, This test has already been temporary disabled in #4512, it should pass after rebase this time. Thanks! |
|
Hi @IvanYashchuk, CI passed and this PR is merged, feel free to open the PR to add |
* Remove deprecated torch.symeig * Remove further references of symeig
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.symeig`. - [x] XLA PR: pytorch/xla#4498 Pull Request resolved: #70988 Approved by: https://github.com/lezcano, https://github.com/kit1980, https://github.com/malfet
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.symeig`. - [x] XLA PR: pytorch/xla#4498 Pull Request resolved: pytorch#70988 Approved by: https://github.com/lezcano, https://github.com/kit1980, https://github.com/malfet
Split #3272 into separate PRs, this PR just removes the symeig function.