Add all-gather and reduce-scatter coalescence support and use that in…#4145
Open
hjm-aws wants to merge 1 commit intopytorch:masterfrom
Open
Add all-gather and reduce-scatter coalescence support and use that in…#4145hjm-aws wants to merge 1 commit intopytorch:masterfrom
hjm-aws wants to merge 1 commit intopytorch:masterfrom
Conversation
… FSDP. Allow using reduce-scatter's scale param in FSDP.
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Oct 18, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Oct 18, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Oct 19, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Oct 20, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Oct 20, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Nov 16, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Nov 18, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Nov 19, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145)
This was referenced Nov 29, 2023
JackCaoG
pushed a commit
that referenced
this pull request
Dec 2, 2023
* Add all-gather and reduce-scatter coalescence support for FSDP. Also allow using reduce-scatter's scale param in FSDP. (revived #4145) * clang-format-7 and python lint fixes * Fix "SyntaxError: 'return' outside function" error * Code/test fixes to get run_tests.sh to run on CPU * Fix allgather to be compatible with openxla allgather tuple change without token * Fix reduce-scatter-coalesce to be compatible with openxla reduce-scatter tuple change without token * Separate out the reduce-scatter-coalesce changes into a separate PR * Some cleanups * Add separate BuildAllGatherCoalesced builder and AllGatherCoalesced class * Use token_handler.GetInput to capture token * Clean up * Clean up * Switch to GetOperandListWithToken naming for func GetOperandList
jeffhataws
added a commit
that referenced
this pull request
Dec 5, 2023
Also allow using reduce-scatter's scale param in FSDP. (revived #4145) Fix reduce-scatter-coalesce to be compatible with openxla reduce-scatter tuple change without token Switch to GetOperandListWithToken naming for func GetOperandList Add separate BuildReduceScatterCoalesced builder Use token_handler.GetInput to consume the token If bucket_size_mb is default 0, reduce-scatter every tensor rather than coalesce Fix error checking in xm.reduce_scatter Move FSDP changes to another PR
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Dec 8, 2023
* Add all-gather and reduce-scatter coalescence support for FSDP. Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145) * clang-format-7 and python lint fixes * Fix "SyntaxError: 'return' outside function" error * Code/test fixes to get run_tests.sh to run on CPU * Fix allgather to be compatible with openxla allgather tuple change without token * Fix reduce-scatter-coalesce to be compatible with openxla reduce-scatter tuple change without token * Separate out the reduce-scatter-coalesce changes into a separate PR * Some cleanups * Add separate BuildAllGatherCoalesced builder and AllGatherCoalesced class * Use token_handler.GetInput to capture token * Clean up * Clean up * Switch to GetOperandListWithToken naming for func GetOperandList
jeffhataws
added a commit
to jeffhataws/xla
that referenced
this pull request
Dec 11, 2023
* Add all-gather and reduce-scatter coalescence support for FSDP. Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145) * clang-format-7 and python lint fixes * Fix "SyntaxError: 'return' outside function" error * Code/test fixes to get run_tests.sh to run on CPU * Fix allgather to be compatible with openxla allgather tuple change without token * Fix reduce-scatter-coalesce to be compatible with openxla reduce-scatter tuple change without token * Separate out the reduce-scatter-coalesce changes into a separate PR * Some cleanups * Add separate BuildAllGatherCoalesced builder and AllGatherCoalesced class * Use token_handler.GetInput to capture token * Clean up * Clean up * Switch to GetOperandListWithToken naming for func GetOperandList
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
* Add all-gather and reduce-scatter coalescence support for FSDP. Also allow using reduce-scatter's scale param in FSDP. (revived pytorch#4145) * clang-format-7 and python lint fixes * Fix "SyntaxError: 'return' outside function" error * Code/test fixes to get run_tests.sh to run on CPU * Fix allgather to be compatible with openxla allgather tuple change without token * Fix reduce-scatter-coalesce to be compatible with openxla reduce-scatter tuple change without token * Separate out the reduce-scatter-coalesce changes into a separate PR * Some cleanups * Add separate BuildAllGatherCoalesced builder and AllGatherCoalesced class * Use token_handler.GetInput to capture token * Clean up * Clean up * Switch to GetOperandListWithToken naming for func GetOperandList
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Add all-gather and reduce-scatter coalescence support for FSDP. Also allow using reduce-scatter's scale param in FSDP. (revived #4145) * clang-format-7 and python lint fixes * Fix "SyntaxError: 'return' outside function" error * Code/test fixes to get run_tests.sh to run on CPU * Fix allgather to be compatible with openxla allgather tuple change without token * Fix reduce-scatter-coalesce to be compatible with openxla reduce-scatter tuple change without token * Separate out the reduce-scatter-coalesce changes into a separate PR * Some cleanups * Add separate BuildAllGatherCoalesced builder and AllGatherCoalesced class * Use token_handler.GetInput to capture token * Clean up * Clean up * Switch to GetOperandListWithToken naming for func GetOperandList
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Add all-gather and reduce-scatter coalescence support for FSDP. Also allow using reduce-scatter's scale param in FSDP. (revived #4145) * clang-format-7 and python lint fixes * Fix "SyntaxError: 'return' outside function" error * Code/test fixes to get run_tests.sh to run on CPU * Fix allgather to be compatible with openxla allgather tuple change without token * Fix reduce-scatter-coalesce to be compatible with openxla reduce-scatter tuple change without token * Separate out the reduce-scatter-coalesce changes into a separate PR * Some cleanups * Add separate BuildAllGatherCoalesced builder and AllGatherCoalesced class * Use token_handler.GetInput to capture token * Clean up * Clean up * Switch to GetOperandListWithToken naming for func GetOperandList
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… FSDP. Allow using reduce-scatter's scale param in FSDP.
This PR depends on tensorflow PR tensorflow/tensorflow#58377