Try to get out of the mess C10 did trying to be Google with logging a…#34
Merged
Try to get out of the mess C10 did trying to be Google with logging a…#34
Conversation
…nd CHECK macros. Was fun to debug why LOG messages disappeared.
asuhan
approved these changes
Dec 3, 2018
Contributor
asuhan
left a comment
There was a problem hiding this comment.
What do you mean by logging messages disappearing? Anyway, makes sense to use Google / standard library (for things like "optional") now that we're an extension.
For resnet50 the differences are way too high, which makes me think there might be something wrong in either the way we use autograd/tracer, or in that infrastructure.
Collaborator
Author
|
Yes, they created the very same macros we have in TF/G3 (LOG, VLOG, CHECK*, ...), with an implementation which is poorer, and sinks logs to /dev/null |
Collaborator
Author
|
I did not noticed you ACK this PR, and slipped one more commit in it. |
asuhan
approved these changes
Dec 3, 2018
Contributor
|
apparently, c10 can just use google glog directly, instead of routing to it's shim, if you have this defined: |
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Aug 8, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Aug 8, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Aug 8, 2024
yitongh
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Aug 8, 2024
anw90
pushed a commit
to AlibabaPAI/xla
that referenced
this pull request
Oct 11, 2024
* build with BladeDISC (#8) * [to #53687860] feat: DISC client header, implement DISCComputation and DISCData POC implement in : https://code.alibaba-inc.com/torchx/xla/codereview/14984824 Link: https://code.alibaba-inc.com/torchx/xla/codereview/14987956 * Disc computation (#2) Support Disc as backend Co-authored-by: yancey.yx <yancey.yx@antfin.com> Co-authored-by: wangang.wa <wangang.wa@alibaba-inc.com> * add bazel flag to disable disc backend (#23) * add flag to disable disc backend in bazel workspace * support disc debug mode to dump mhlo and logs (#25) support disc backend debug mode to dump DISC compilation logs * support flash attention in disc (pytorch#34) * fix disc flag when complie python (pytorch#39) * fix bazel flag when complie python * fix lint. * support bf16 on disc backend (pytorch#40) add float-norm pass to support bf16 amp training * Support Flash Attention 2.5.6 for disc backend (#4) * fix build failed with NCCL (#5) * fix build failed on nccl * using nccl hdrs * Use the value of DISC_DEVICE as the device type of disc backend (#8) * change the device type of disc to cuda to make amp work properly * Use the value of DISC_DEVICE as the device type of disc backend * disable compilation of DISC by default (#15) --------- Co-authored-by: Yan Xu <yancey1989@gmail.com> Co-authored-by: wenting.swt <wenting.swt@alibaba-inc.com> Co-authored-by: Dalong <yuanxiulong.yxl@alibaba-inc.com> Co-authored-by: Baole Ai <baole.abl@alibaba-inc.com> Co-authored-by: Yan Xu <yancey.yx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fun with C10 wannabe Google macros.