Fix code generation for new ScalarList type#2816
Merged
Merged
Conversation
We are going to introduce ScalarList = ArrayRef<Scalar> in PyTorch.
Contributor
Author
|
cc @smessmer |
wenleix
added a commit
to wenleix/xla
that referenced
this pull request
Mar 30, 2021
This reverts commit e537eed. We decide not to introduce ScalarList as an alias for ArrayRef<Scalar> but to use ArrayRef<Scalar> directly in pytorch/pytorch#53583. The original commit is no longer needed.
wenleix
added a commit
that referenced
this pull request
Mar 31, 2021
This reverts commit e537eed. We decide not to introduce ScalarList as an alias for ArrayRef<Scalar> but to use ArrayRef<Scalar> directly in pytorch/pytorch#53583. The original commit is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are going to introduce ScalarList = ArrayRef in PyTorch.
See pytorch/pytorch#53470 for context.