Dispatch aten::maximum and aten::minimum to XLATensor::max and XLATen…#2438
Merged
Dispatch aten::maximum and aten::minimum to XLATensor::max and XLATen…#2438
Conversation
Collaborator
Author
|
pytorch change pytorch/pytorch#42579 doesn't have the AutogradXLA renaming change, hence the build will fail. I will ask if they can rebase. I patched the pytorch change and run python tests locally. All of the affected test passed. |
davidel
approved these changes
Aug 18, 2020
8cfef42 to
09ba6c4
Compare
Collaborator
Author
|
Dsiable |
davidel
approved these changes
Aug 20, 2020
Contributor
|
Hey PyTorch/XLA team - is this OK to go in? We'd like to unblock pytorch/pytorch#42579. |
Collaborator
Author
|
@mruberry yup, I will remove the pin and merge this pr after pytorch one merged. |
09ba6c4 to
6f675c8
Compare
cjolivier01
pushed a commit
to cjolivier01/pytorch_xla
that referenced
this pull request
Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sor::min
Fixes #2424. Make maximum and minimum perform pytorch type promotion too.