clamping_mode: Rename 'none' to None and None to 'auto'#9132
Merged
NicolasHug merged 18 commits intopytorch:mainfrom Jul 1, 2025
Merged
clamping_mode: Rename 'none' to None and None to 'auto'#9132NicolasHug merged 18 commits intopytorch:mainfrom
NicolasHug merged 18 commits intopytorch:mainfrom
Conversation
Test Plan: ```bash pytest test/test_transforms_v2.py -k box -v ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9132
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dc07d27 with merge base 80cb38e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
AntoineSimoulin
approved these changes
Jun 30, 2025
Member
AntoineSimoulin
left a comment
There was a problem hiding this comment.
Looking good to me. Thanks for the PR @NicolasHug!
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
AntoineSimoulin
added a commit
to AntoineSimoulin/vision
that referenced
this pull request
Jul 1, 2025
Co-authored-by: Antoine Simoulin <antoinesimoulin@fb.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
Summary: Co-authored-by: Antoine Simoulin <antoinesimoulin@fb.com> Reviewed By: AntoineSimoulin Differential Revision: D79175061 fbshipit-source-id: 8917698aca2a4c1a2702c17196984c141079af70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
clamping_modeattribute of aBoundingBoxesobject to beNoneinstead of"none".It also changes the default value of
clamping_modeparameter inClampingBoundingBoxesfromNoneto"auto"to resolve a resulting conflict.cc @vfdev-5