Conversation
DeformConv is only implemented for forward on MPS right now, so skip backward checks Logic for modifying markers in place are stolen from `torch.testing._internal.optests`, namely from https://github.com/pytorch/pytorch/blob/310e8361c565ca1602e719e4c812dc3931ec84d7/torch/testing/_internal/optests/generate_tests.py#L269
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9120
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 29 PendingAs of commit 3c7a7ad with merge base 89f5855 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
reviewed
Jun 25, 2025
test/test_ops.py
Outdated
| torch.jit.script(ops.DeformConv2d(in_channels=8, out_channels=8, kernel_size=3)) | ||
|
|
||
|
|
||
| # NS: Removeme once bacward is implemented |
huydhn
approved these changes
Jun 25, 2025
Camyll
approved these changes
Jun 25, 2025
seemethere
approved these changes
Jun 25, 2025
|
Hey @malfet! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Summary: DeformConv is only implemented for forward on MPS right now, so skip backward checks Logic for modifying markers in place are stolen from `torch.testing._internal.optests`, namely from https://github.com/pytorch/pytorch/blob/310e8361c565ca1602e719e4c812dc3931ec84d7/torch/testing/_internal/optests/generate_tests.py#L269 Reviewed By: AntoineSimoulin Differential Revision: D79175050 fbshipit-source-id: 8b0ee6bad5adb9cc30ce2deeb8ea659b90d73a52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeformConv is only implemented for forward on MPS right now, so skip
backward checks
Logic for modifying markers in place are stolen from
torch.testing._internal.optests, namely from https://github.com/pytorch/pytorch/blob/310e8361c565ca1602e719e4c812dc3931ec84d7/torch/testing/_internal/optests/generate_tests.py#L269