Add libwebp to contributing doc#9119
Merged
NicolasHug merged 3 commits intopytorch:mainfrom Jun 24, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9119
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 6bb8f8b with merge base 7b283c2 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Reviewed By: AntoineSimoulin Differential Revision: D79175023 fbshipit-source-id: e298632e8c025757316a0569556b12062f2333be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
libwebpto the contributing doc. Previously, it was not there and if you followed the default instructions, the webp tests would fail.Note that libwebp pulls in standard jpeg, so we end up having both
jpegandlibjpeg-turboinstalled. All tests pass in my Linux environment, though, so I assume we're usinglibjpeg-turboat runtime. It's worth noting what we do for CI. On Linux, we install both much the same as what I'm putting in our contributing doc:vision/packaging/pre_build_script.sh
Lines 36 to 37 in 7b283c2
But on Mac, we do this dance:
vision/packaging/pre_build_script.sh
Lines 16 to 21 in 7b283c2
I bring this up because our Mac contributors might run into the above.