Skip to content

Add error message when setting 1D tensor ToImage()#9114

Merged
NicolasHug merged 4 commits intopytorch:mainfrom
chengolivia:add-error-message-dims
Jun 23, 2025
Merged

Add error message when setting 1D tensor ToImage()#9114
NicolasHug merged 4 commits intopytorch:mainfrom
chengolivia:add-error-message-dims

Conversation

@chengolivia
Copy link
Copy Markdown
Contributor

@chengolivia chengolivia commented Jun 23, 2025

As per #9025, I added a descriptive error message to the torchvision.transforms.v2.ToImage() method when a 1D tensor is passed in.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jun 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9114

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 23, 2025

Hi @chengolivia!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@chengolivia chengolivia marked this pull request as ready for review June 23, 2025 15:23
@chengolivia
Copy link
Copy Markdown
Contributor Author

chengolivia commented Jun 23, 2025

Tested with the following test.py script:

import torch
from torchvision.datasets import OxfordIIITPet
from torchvision.transforms.v2 import ToImage

my_data = OxfordIIITPet(
    root="data"
)

ti = ToImage()

ti(torch.tensor([0]))

Output:

Traceback (most recent call last):
  File "/Users/oliviacheng/projects/oss/vision/test.py", line 11, in <module>
    ti(torch.tensor([0]))
    ~~^^^^^^^^^^^^^^^^^^^
  File "/Users/oliviacheng/miniconda3/envs/pytorch-dev/lib/python3.13/site-packages/torch/nn/modules/module.py", line 1773, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/Users/oliviacheng/miniconda3/envs/pytorch-dev/lib/python3.13/site-packages/torch/nn/modules/module.py", line 1784, in _call_impl
    return forward_call(*args, **kwargs)
  File "/Users/oliviacheng/projects/oss/vision/torchvision/transforms/v2/_transform.py", line 69, in forward
    self.transform(inpt, params) if needs_transform else inpt
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/Users/oliviacheng/projects/oss/vision/torchvision/transforms/v2/_type_conversion.py", line 39, in transform
    return F.to_image(inpt)
           ~~~~~~~~~~^^^^^^
  File "/Users/oliviacheng/projects/oss/vision/torchvision/transforms/v2/functional/_type_conversion.py", line 23, in to_image
    return tv_tensors.Image(output)
           ~~~~~~~~~~~~~~~~^^^^^^^^
  File "/Users/oliviacheng/projects/oss/vision/torchvision/tv_tensors/_image.py", line 46, in __new__
    raise ValueError(f"Tensor must be 2D or higher, got {tensor.ndim}D tensor.")
ValueError: Tensor must be 2D or higher, got 1D tensor.

@chengolivia
Copy link
Copy Markdown
Contributor Author

chengolivia commented Jun 23, 2025

Closes #9025

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 23, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

NicolasHug
NicolasHug approved these changes Jun 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for the PR @chengolivia

@NicolasHug NicolasHug merged commit 7b283c2 into pytorch:main Jun 23, 2025
1 check passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 23, 2025

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jul 30, 2025
@NicolasHug @facebook-github-bot
[fbsync] Add error message when setting 1D tensor ToImage() (#9114)
622dd23 
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: AntoineSimoulin

Differential Revision: D79175021

fbshipit-source-id: a4345beae9801f31b30f6394452f07adf7bcf4fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed enhancement module: tv_tensors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chengolivia @facebook-github-bot @NicolasHug