Skip to content

Add label background#9018

Merged
AntoineSimoulin merged 7 commits intopytorch:mainfrom
AntoineSimoulin:add-label-background
Apr 16, 2025
Merged

Add label background#9018
AntoineSimoulin merged 7 commits intopytorch:mainfrom
AntoineSimoulin:add-label-background

Conversation

@AntoineSimoulin
Copy link
Copy Markdown
Member

@AntoineSimoulin AntoineSimoulin commented Apr 14, 2025 •
edited
Loading

Context

This PR add the ability to add background color for the label of bounding boxes. In this case, the background label will be the same as the one used for the box frame. The text itself will automatically be switched to black. This should allow better visibility in cases where brightness and darkness prevent from distinguishing regular labels, as mentioned in #8317

How to use

We add a fill_labels parameter in the draw_bounding_boxes function. As illustrated below, this will draw a colored rectangle with the same size of the text rectangle for the text label. By default, the option is deactivated.

boxes = torch.tensor(
    [[100, 100, 150, 150], [50, 50, 100, 100], [300, 100, 400, 300]],
    dtype=torch.float32,
)

image = torch.ones((3, 500, 500), dtype=torch.uint8) * 255

colors = ["blue", "yellow", "red"]
image = draw_bounding_boxes(
    image, boxes, colors=colors, width=1, fill=False, labels=colors, fill_labels=True
)
plt.imshow(image.numpy().transpose((1, 2, 0)))
plt.axis("off")
plt.show()

image

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9018

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 670ffa5 with merge base ac7ad5f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug reviewed Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @AntoineSimoulin , this looks good! I made some minor comments below, it'd be also great to have some small test to check the expected behavior, similar to the existing tests we have for draw_bounding_boxes

torchvision/utils.py Outdated
draw.rectangle(
(left - box_margin, top - box_margin, right + box_margin, bottom + box_margin), fill=color
)
label_color = "black"
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any reason to force label_color to black? Could we just make black the default, but let the user specify it if they wanted to?

AntoineSimoulin and others added 2 commits April 15, 2025 08:56
@AntoineSimoulin @NicolasHug
Apply suggestions from code review
69a320e 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@AntoineSimoulin
Let user specify label_color
2e72bbb
@AntoineSimoulin
Copy link
Copy Markdown
Member Author

AntoineSimoulin commented Apr 15, 2025

@NicolasHug, thanks for the comments. I did the following modifications:

  • Let the user choose the background color and default to black otherwise in 2e72bbb;
  • Added some tests in 9f9e320, similar to the existing tests we have for draw_bounding_boxes. Please run with pytest test/test_utils.py -vvv -k test_draw_boxes_with_coloured_label_backgrounds.

NicolasHug
NicolasHug approved these changes Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

AntoineSimoulin and others added 3 commits April 16, 2025 08:03
@AntoineSimoulin @NicolasHug
Update torchvision/utils.py
ae6dafb 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@AntoineSimoulin @NicolasHug
Update torchvision/utils.py
697a358 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@AntoineSimoulin
Merge branch 'main' into add-label-background
670ffa5
@AntoineSimoulin AntoineSimoulin merged commit f799a53 into pytorch:main Apr 16, 2025
58 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2025

Hey @AntoineSimoulin!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@AntoineSimoulin AntoineSimoulin mentioned this pull request Apr 17, 2025
Open
facebook-github-bot pushed a commit that referenced this pull request Jul 30, 2025
@NicolasHug @facebook-github-bot
[fbsync] Add label background (#9018)
528e890 
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: AntoineSimoulin

Differential Revision: D79175033

fbshipit-source-id: 10091733ee5bc1a7e31f80c7bf1569a525c91603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AntoineSimoulin @NicolasHug @facebook-github-bot