Skip to content

A temporary fix to windows unittests failing in INaturalistTestCase.#9007

Merged
NicolasHug merged 3 commits intopytorch:mainfrom
GdoongMathew:fix/inaturalist_unittests
Apr 1, 2025
Merged

A temporary fix to windows unittests failing in INaturalistTestCase.#9007
NicolasHug merged 3 commits intopytorch:mainfrom
GdoongMathew:fix/inaturalist_unittests

Conversation

@GdoongMathew
Copy link
Copy Markdown
Contributor

@GdoongMathew GdoongMathew commented Mar 27, 2025

Summary

Temporary fix issue where tmp directory couldn't be removed during testing.
https://github.com/pytorch/vision/actions/runs/14085345925

cc @NicolasHug (Not sure if this kind of temp fix is needed)

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9007

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d20e31 with merge base 309bd7a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@GdoongMathew
Copy link
Copy Markdown
Contributor Author

GdoongMathew commented Mar 31, 2025 •
edited
Loading

Update:
So the root cause is because of the loader argument. The loader was stored in the INaturalist attribute before the function is being mocked, and that's why the unittests failed. Once I changed to setting the loader during __getitem__, the issue no longer exists.

NicolasHug
NicolasHug approved these changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @GdoongMathew

@NicolasHug NicolasHug merged commit ef4718a into pytorch:main Apr 1, 2025
58 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@GdoongMathew GdoongMathew deleted the fix/inaturalist_unittests branch April 1, 2025 15:55
facebook-github-bot pushed a commit that referenced this pull request Jul 30, 2025
@NicolasHug @facebook-github-bot
[fbsync] A temporary fix to windows unittests failing in `INaturalist…
b79a1fb 
…TestCase`. (#9007)

Reviewed By: AntoineSimoulin

Differential Revision: D79175051

fbshipit-source-id: 9e8e6e9168f9e3cd79803e5de15f884582fc013e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed module: datasets module: tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GdoongMathew @NicolasHug @facebook-github-bot