Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8925
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Mar 18, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
Reviewed By: scotts Differential Revision: D77998631 fbshipit-source-id: 53f67590af85c04d16ebe6536bdddb9e60732331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #8766 now merged, a normal call to
nms()is able to handle much more boxes while staying fast. This PR updates our internal heuristic inbatched_nms()to switch between the coordinate trick and the for-loop-based approach.100_000seems to be a decent new threshold.Details