Merged
Conversation
Corrected the order of aux1 and aux2.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8743
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Nov 27, 2024
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks for the report and for the fix @pblwk .
It looks like the bug was introduced in eellison@9cdc814 a long time ago.
As far as I can tell, this fix should only affect code when model.training is True, so the existing training weights aren't affected (although they might have been trained with this bug). So risk of breaking user's code with this fix should be minimal.
Member
|
CI is failing with tons of unrelated failure that are visible on main as well. Landing. |
Contributor
Author
|
Thanks a lot @NicolasHug 👍 : D |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Reviewed By: vmoens Differential Revision: D68021966 fbshipit-source-id: c5789a1233fb858a1ae3357b0b3280f5a0986ea8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the order of aux1 and aux2.
Please see Issue #8736 for details.