[MPS] Lift MSL version to 3.0+ and use relevant helpers#8719
Merged
malfet merged 2 commits intopytorch:mainfrom Nov 11, 2024
Merged
[MPS] Lift MSL version to 3.0+ and use relevant helpers#8719malfet merged 2 commits intopytorch:mainfrom
malfet merged 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8719
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 16 Unrelated FailuresAs of commit 21e09dc with merge base 4249b61 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Nov 8, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
Thank you for the BE change
|
Hey @malfet! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Summary: 1. Remove the custom atomic add function and use the one provided by MSL 3.0+ instead. 2. Use `MetalShaderLibrary` class. Reviewed By: vmoens Differential Revision: D68021975 fbshipit-source-id: 0350d376e0ff3e2ea0e06ce7cacdc33eedfbc84d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
MetalShaderLibraryclass.cc @malfet @kulinseth