Skip to content

Expose transforms.v2 utils for writing custom transforms.#8670

Merged
NicolasHug merged 2 commits intopytorch:mainfrom
venkatram-dev:make_public_query_size
Oct 3, 2024
Merged

Expose transforms.v2 utils for writing custom transforms.#8670
NicolasHug merged 2 commits intopytorch:mainfrom
venkatram-dev:make_public_query_size

Conversation

@venkatram-dev
Copy link
Copy Markdown
Contributor

@venkatram-dev venkatram-dev commented Oct 3, 2024 •
edited by pytorch-bot bot
Loading

#7785 (comment)

pytest test/test_transforms_v2.py -vvv -k test_functional

test/test_transforms_v2.py::TestQuerySize::test_functional[pure_tensor] PASSED                                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_image] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[pil_image] PASSED                                           [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_video] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_mask] PASSED                                      [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pure_tensor] PASSED                             [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_image] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pil_image] PASSED                               [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_video] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_mask] PASSED                          [100%]

cc @vfdev-5

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Oct 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8670

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 1f24d8f with merge base 9832166 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@venkatram-dev
Copy link
Copy Markdown
Contributor Author

venkatram-dev commented Oct 3, 2024 

pytest test/test_transforms_v2.py -vvv -k test_functional

test/test_transforms_v2.py::TestQuerySize::test_functional[pure_tensor] PASSED                                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_image] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[pil_image] PASSED                                           [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_video] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_mask] PASSED                                      [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pure_tensor] PASSED                             [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_image] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pil_image] PASSED                               [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_video] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_mask] PASSED                          [100%]

@NicolasHug NicolasHug changed the title make_public_query_size Expose transforms.v2 utils for writing custom transforms. Oct 3, 2024
@NicolasHug
Copy link
Copy Markdown
Member

NicolasHug commented Oct 3, 2024

Thanks for the initial PR @venkatram-dev . Note that tests were failing for different reasons, the main one being that query_size was imported from the wrong module (I assume your code changed since you last tested?)

I fixed and cleaned up the tests, added some more test cases, and exposed a few more utils. Thank you!

@NicolasHug NicolasHug merged commit f0ed07d into pytorch:main Oct 3, 2024
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Oct 3, 2024
@venkatram-dev @NicolasHug
Expose transforms.v2 utils for writing custom transforms. (pytorch#…
d163c95 
…8670)

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
This was referenced Oct 3, 2024
Merged
Closed
facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2025
@NicolasHug @facebook-github-bot
[fbsync] Expose transforms.v2 utils for writing custom transforms. (#…
e7711ce 
…8670)

Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D68021985

fbshipit-source-id: 7c6026d36a972965daf9139f66b0b38d475cd935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed enhancement module: transforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@venkatram-dev @NicolasHug @facebook-github-bot