Allow custom package name for CI builds of torchvision#8659
Allow custom package name for CI builds of torchvision#8659NicolasHug merged 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8659
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit b42e4ab with merge base fc74637 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @amd-jmacaran! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
NicolasHug
left a comment
There was a problem hiding this comment.
SGTM, thanks for the PR @amd-jmacaran
Reviewed By: vmoens Differential Revision: D68021984 fbshipit-source-id: 4c0ac73e8270a46eda80268caa548d13e5da50dd
Mirroring what is done in the pytorch repo: https://github.com/pytorch/pytorch/blob/main/setup.py#L347
This is to accommodate custom package naming for CI builds if additional metadata is to be added, outside of the version string.
cc @seemethere