Cleanup video decoder build stuff#8602
Merged
NicolasHug merged 2 commits intopytorch:mainfrom Aug 19, 2024
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8602
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f1e2328 with merge base be7cdf1 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
Reviewed By: ahmadsharif1 Differential Revision: D62032050 fbshipit-source-id: 3b3dcbc5b5966f1d29195247008e1f80f2cb6674
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up a bit the spaghetti that the video decoder build has become over the years. Using more descriptive names where possible and simplify build system. This is still a proper mess, just a bit more tractable.
Oh, and since this is entirely untested, I'm probably breaking builds in some way. It's not release-facing though. We'll fix stuff if issues get opened.