Allow io.write_video to work with video_arrays on different devices by bmmtstb · Pull Request #8537 · pytorch/vision

bmmtstb · 2024-07-18T17:21:59Z

torchvision.io.write_video() fails if the video_array is on other devices, due to .numpy() not being able to convert properly.

Used .numpy(force=True) to make sure tensors on other devices get converted properly.

Added tests (which I can't test locally due to PyAV)

pytorch-bot · 2024-07-18T17:22:02Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8537

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 6 Unrelated Failures

As of commit bd6f0a4 with merge base 4a1cb63 ():

NEW FAILURES - The following jobs have failed:

CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Lint / python-types / linux-job (gh)
RuntimeError: Command docker exec -t d08e198640bd6240c9805ac6d7b379fda6739f2c322cb539e0cbb4f318447bda /exec failed with exit code 1
Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh)
test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
Tests / unittests-macos (3.10, macos-m1-stable) / macos-job (gh)
test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
Tests / unittests-macos (3.12, macos-m1-stable) / macos-job (gh)
test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-macos (3.9, macos-m1-stable) / macos-job (gh)
test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

Tests / unittests-linux (3.12, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Build Windows Conda / pytorch/vision / upload / conda-py3_8-cpu (gh) (trunk failure)
Unable to find any artifacts for the associated workflow
Build Windows Conda / pytorch/vision / upload / conda-py3_8-cuda11_8 (gh) (trunk failure)
Unable to find any artifacts for the associated workflow
Build Windows Conda / pytorch/vision / upload / conda-py3_8-cuda12_1 (gh) (trunk failure)
Unable to find any artifacts for the associated workflow
Build Windows Conda / pytorch/vision / upload / conda-py3_8-cuda12_4 (gh) (trunk failure)
Unable to find any artifacts for the associated workflow

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug

Thank you @bmmtstb

Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Reviewed By: vmoens Differential Revision: D60596226 fbshipit-source-id: b9ea4916a82a9e7c0e768ce329c3b9d88503f5ab

Allow write_video to work with video_arrays on cuda devices

61994a0

facebook-github-bot added the cla signed label Jul 18, 2024

bmmtstb changed the title ~~Allow io.write_video to work with video_arrays on cuda devices~~ Allow io.write_video to work with video_arrays on different devices Jul 18, 2024

bmmtstb and others added 2 commits July 23, 2024 13:56

Merge branch 'main' into main

c08b63f

Merge branch 'main' into main

bd6f0a4

NicolasHug approved these changes Jul 25, 2024

View reviewed changes

NicolasHug merged commit 3e60dbd into pytorch:main Jul 25, 2024

NicolasHug added enhancement module: io labels Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow io.write_video to work with video_arrays on different devices#8537

Allow io.write_video to work with video_arrays on different devices#8537
NicolasHug merged 3 commits intopytorch:mainfrom
bmmtstb:main

bmmtstb commented Jul 18, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 18, 2024 •

edited

Loading

Uh oh!

NicolasHug left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bmmtstb commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8537

❌ 15 New Failures, 6 Unrelated Failures

Uh oh!

NicolasHug left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bmmtstb commented Jul 18, 2024 •

edited

Loading

pytorch-bot bot commented Jul 18, 2024 •

edited

Loading