Merged
Conversation
YosuaMichael
approved these changes
Oct 18, 2022
Contributor
YosuaMichael
left a comment
There was a problem hiding this comment.
Thanks @pmeier , this is a good short term fix for the CI!
NicolasHug
reviewed
Oct 18, 2022
NicolasHug
reviewed
Oct 18, 2022
Contributor
Author
|
The new CPU tests on GHA are also affected. I need to fix them as well. Please do not merge until further notice. |
Contributor
Author
|
The only CI failures left are the ones reported in #6794. |
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Summary: * pin pyav to <10 * pin av in GHA workflows as well * also pin in M1 workflow Reviewed By: YosuaMichael Differential Revision: D40588161 fbshipit-source-id: 7583178f8f7697a4b4e3a9e518ae2f81e00b535f
YosuaMichael
pushed a commit
to YosuaMichael/vision
that referenced
this pull request
Oct 27, 2022
* pin pyav to <10 * pin av in GHA workflows as well * also pin in M1 workflow
This was referenced Oct 27, 2022
atalman
pushed a commit
that referenced
this pull request
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6790. This is meant as a short term fix to get the CI green again as there are multiple failures going on right now. As suggested offline, I think it would be best for the video maintainers to have a look and see if this comes from
avavIf we have a clearer picture, this PR can be reverted and whatever reasonable fix can be merged.