Merged
Conversation
jdsgomes
approved these changes
Oct 18, 2022
Contributor
jdsgomes
left a comment
There was a problem hiding this comment.
LGTM, just left a NIT which is just a suggestion
Contributor
Author
|
The CI breakage is unrelated, and the PR pass the prototype test which should be good enough. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Summary: * Add raft_stereo weights * Update the metrics layout Reviewed By: YosuaMichael Differential Revision: D40588172 fbshipit-source-id: 32c56534abc6f71effcf25ff11f906306cec34fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding weights for raft stereo models