Update ToDtype to avoid unnecessary to() calls and fixing types on Transform#6773
Merged
datumbox merged 6 commits intopytorch:mainfrom Oct 14, 2022
Merged
Update ToDtype to avoid unnecessary to() calls and fixing types on Transform#6773datumbox merged 6 commits intopytorch:mainfrom
ToDtype to avoid unnecessary to() calls and fixing types on Transform#6773datumbox merged 6 commits intopytorch:mainfrom
Conversation
Contributor
Author
|
Fun behaviour of defaultdict: |
ToDtype to avoid errors when a type is not defined.ToDtype to avoid unnecessary to() calls and fixing types on Transform
pmeier
approved these changes
Oct 14, 2022
Contributor
Author
|
The failing test is unrelated (the flaky gaussian), we are good to go. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
…g types on `Transform` (#6773) Summary: * Fix `ToDtype` to avoid errors when a type is not defined. * Nit `(features.is_simple_tensor, features._Feature)` to `(Tensor,)` * Fixing linter * Adding comment. * Switch back to indexing. Python's default dict seems to have a nasty behaviour. Reviewed By: NicolasHug Differential Revision: D40427458 fbshipit-source-id: 8b104b0f29e717f216a95bae3aaa5a362b880d6e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed offline this PR:
.to(None)call_transformed_typesofTransformto avoid the superfluousfeatures.is_simple_tensor, features._Featureidiom.