Skip to content

Fix errors on non-contiguous tensors in equalize() Tensor-backend#6772

Merged
datumbox merged 1 commit intopytorch:mainfrom
datumbox:bugfix/equalize_view
Oct 14, 2022
Merged

Fix errors on non-contiguous tensors in equalize() Tensor-backend#6772
datumbox merged 1 commit intopytorch:mainfrom
datumbox:bugfix/equalize_view

Conversation

@datumbox
Copy link
Copy Markdown
Contributor

@datumbox datumbox commented Oct 14, 2022

The use of view() in equalize() leads to the following errors when the input is non-contiguous. The problem affects stable:

    hist = torch.bincount(img_chan.view(-1), minlength=256)
RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.

And prototype:

  File "./torchvision/prototype/transforms/functional/_color.py", line 237, in equalize_video
    return equalize_image_tensor(video)
  File "./torchvision/prototype/transforms/functional/_color.py", line 230, in equalize_image_tensor
    return _equalize_image_tensor_vec(image.view(-1, height, width)).view(image.shape)
  File "./torchvision/prototype/features/_feature.py", line 94, in __torch_function__
    output = func(*args, **kwargs or dict())
RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.

It was first discovered after starting doing end-to-end training with complex Augmentations using the Tensor Backend. The PR updates the use of view() to reshape() to ensure that both operators work as expected.

@datumbox datumbox requested review from pmeier and vfdev-5 October 14, 2022 12:25
pmeier
pmeier approved these changes Oct 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vasilis!

@datumbox datumbox merged commit c960273 into pytorch:main Oct 14, 2022
@datumbox datumbox deleted the bugfix/equalize_view branch October 14, 2022 12:34
@datumbox datumbox mentioned this pull request Oct 14, 2022
Merged
@pmeier pmeier mentioned this pull request Oct 14, 2022
Merged
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
@facebook-github-bot
[fbsync] Switch view() with reshape() on equalize (#6772)
92c8523 
Reviewed By: NicolasHug

Differential Revision: D40427466

fbshipit-source-id: 77c8a8aa1d7169ece7d046d591f1c96def0ad29d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

1 more reviewer

@pmeier pmeier pmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug cla signed module: transforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@datumbox @pmeier @facebook-github-bot